-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: type-check trait default methods #6645
Open
asterite
wants to merge
8
commits into
master
Choose a base branch
from
ab/type-check-trait-default-methods
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asterite
changed the title
fix: type-check trait default methods
feat!: type-check trait default methods
Dec 23, 2024
asterite
force-pushed
the
ab/type-check-trait-default-methods
branch
2 times, most recently
from
December 23, 2024 19:15
150b2b4
to
52c1332
Compare
asterite
force-pushed
the
ab/type-check-trait-default-methods
branch
from
December 23, 2024 19:15
52c1332
to
742b8d0
Compare
Peak Memory Sample
|
Compilation Sample
|
Execution Sample
|
…-lang/noir into ab/type-check-trait-default-methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem
Resolves #6519
Summary
This is a breaking change because this code used to compile:
That is, you could access a member of
self
in a trait method. Because the trait default method was checked against the actual concrete type, if it had a memberx
it compiled fine. Now that code is rejected (like in Rust). And... we have code like that in Aztec-Packages.Additional Context
Documentation
Check one:
PR Checklist
cargo fmt
on default settings.